Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show explicit error message for SSSP run over a graph with no edge weight #2929

Merged
merged 6 commits into from
Jun 27, 2023
Merged

Show explicit error message for SSSP run over a graph with no edge weight #2929

merged 6 commits into from
Jun 27, 2023

Conversation

doudoubobo
Copy link
Collaborator

@doudoubobo doudoubobo commented Jun 26, 2023

Fixes #1878

Signed-off-by: wang <jiede.wl@alibaba-inc.com>
Signed-off-by: wang <jiede.wl@alibaba-inc.com>
@codecov-commenter
Copy link

Codecov Report

Merging #2929 (9a43220) into main (34b3650) will decrease coverage by 7.76%.
The diff coverage is 71.42%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2929      +/-   ##
==========================================
- Coverage   73.96%   66.21%   -7.76%     
==========================================
  Files          99       99              
  Lines       10672    10668       -4     
==========================================
- Hits         7894     7064     -830     
- Misses       2778     3604     +826     
Impacted Files Coverage Δ
python/graphscope/analytical/app/sssp.py 86.66% <71.42%> (-13.34%) ⬇️

... and 19 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34b3650...9a43220. Read the comment docs.

Signed-off-by: wang <jiede.wl@alibaba-inc.com>
@sighingnow sighingnow merged commit ae8d96c into alibaba:main Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explicit error message for SSSP run over a graph with no edge weight
3 participants